Skip to content

box: added logic for working with Tarantool schema #446

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

bigbes
Copy link

@bigbes bigbes commented Jun 20, 2025

Implemented the box.Schema() method that returns a Schema object for schema-related operations.

Co-authored-by: maksim.konovalov [email protected]

@bigbes bigbes force-pushed the bigbes/TNTP-3331-box-schema-wrappers branch from 5d1b376 to b869130 Compare June 20, 2025 16:46
@oleg-jukovec
Copy link
Collaborator

Is this PR ready for review? If so, please assign two reviewers from the team (usually one of them is the repository maintainer, but it is not necessary).

@oleg-jukovec
Copy link
Collaborator

The dot is missed.

Implemented the `box.Schema()` method that returns a `Schema`
object for schema-related operations

->

Implemented the `box.Schema()` method that returns a `Schema`
object for schema-related operations.

@oleg-jukovec
Copy link
Collaborator

oleg-jukovec commented Jun 20, 2025

original-author: maksim.konovalov <[email protected]>
original-date:   Tue Dec 24 11:25:05 2024 +0300

It looks a bit ugly for me. For example, I don’t understand why the timestamp might be useful to us. I like the co-authored-by label in the commit message instead:

Co-authored-by: NAME <[email protected]>

But up to you.

Implemented the `box.Schema()` method that returns a `Schema`
object for schema-related operations.

Co-authored-by: maksim.konovalov <[email protected]>
@bigbes bigbes force-pushed the bigbes/TNTP-3331-box-schema-wrappers branch from b869130 to fc70848 Compare June 23, 2025 18:07
@bigbes bigbes marked this pull request as draft June 23, 2025 18:09
@bigbes bigbes force-pushed the bigbes/TNTP-3331-box-schema-wrappers branch from fc70848 to afcd25f Compare June 24, 2025 13:49
* preemptive checking for empty connection
* hide constructors for schema and etc
* redo (minify) API for box.session.su (simplify it)
* added mock tests to check API
@bigbes bigbes force-pushed the bigbes/TNTP-3331-box-schema-wrappers branch from afcd25f to fab4d84 Compare June 24, 2025 13:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants